I guess if you're preparing for exams it's usually considered a closed system because it's a calorimeter and technically there shouldn't be any transfer of heat between what's in the cup and surroundings.
But well you know it's not perfect and there is a lot of heat loss to the surroundings etc, and water vapour can evaporate etc, so it's actually an open system in practice.