More concentrated solutions are the best, but you want ions, so solids are at least slightly problematical. A solid can still vaporize and ionize, but a solution is better than a precipitate. An acid is a good way to be sure of ionization. Nitrates are often favored, but HCl dissolves most metals that give definitive colors to flames. Simple anions don't generally have a big effect, I'm talking chloride, nitrate, sulfate here: the flame color of metal salt where the anion contains a metal with a strong color itself is going to be a problem. I had heard, for pyrotechnic pot fire, that copper salts in the presence of ammonium salt and chloride ion gives a strong blue color instead of green, so you should try to select very simple salts.